Throwing in sqlite filter function crashes process

[jasnell]

Version

current

Platform

all

Subsystem

sqlite

What steps will reproduce the bug?

  database2.applyChangeset(session.changeset(), {
    filter() { throw new Error('boom'); }
  });

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Error is thrown

What do you see instead?

Process crashes

Additional information

No response

[jasnell]

/cc @cjihrig

[jasnell]

Fixing the issue will necessitate refactoring the xFilter static function used in the DatabaseSync::ApplyChangeset method in node_sqlite

[cjihrig]

I'll take a look, but cc @louwers who worked on the session extension.

[louwers]

I can take a look.

[jasnell]

@louwers ... the key issue, if it's not obvious, is that the filter callback function is using ToLocalChecked() within the filter callback. If the callback throws, then the returned value from the callback will be empty causing ToLocalChecked to trigger the abort. Instead the thrown error should be allowed to propagate. However, because of the way the xFilter callback is set up it's not immediately obvious what should change. We essentially need a way of allowing that API to return an error code that means "Hey, v8 scheduled an error, throw it instead"

[cjihrig]

We essentially need a way of allowing that API to return an error code that means "Hey, v8 scheduled an error, throw it instead"

Something like #56787 might work if it can ever get merged.

[louwers]

I created a PR: #56903