From dbb05325902ced0cffc6d852c10fbf9951efcccc Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Sat, 1 Feb 2025 20:43:10 -0800
Subject: [PATCH] src,test: expand test coverage for urlpattern and fix error

---
 src/node_url_pattern.cc                |  8 +++--
 test/parallel/test-urlpattern-types.js | 46 ++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 3 deletions(-)
 create mode 100644 test/parallel/test-urlpattern-types.js

diff --git a/src/node_url_pattern.cc b/src/node_url_pattern.cc
index 3d6340565d1e06..cbe1b473f0d54b 100644
--- a/src/node_url_pattern.cc
+++ b/src/node_url_pattern.cc
@@ -103,13 +103,14 @@ URLPatternRegexProvider::regex_search(std::string_view input,
       return std::nullopt;
     }
 
+    // V8 checks that the regexp exec result is one of the correct types.
+    DCHECK_IMPLIES(!entry->IsUndefined(), entry->IsString());
+
     if (entry->IsUndefined()) {
       result.emplace_back(std::nullopt);
     } else if (entry->IsString()) {
       Utf8Value utf8_entry(isolate, entry.As<String>());
       result.emplace_back(utf8_entry.ToString());
-    } else {
-      UNREACHABLE("v8::RegExp::Exec return a non-string, non-undefined value.");
     }
   }
   return result;
@@ -184,7 +185,8 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
         return;
       }
     } else {
-      THROW_ERR_MISSING_ARGS(env, "baseURL or options must be provided");
+      THROW_ERR_INVALID_ARG_TYPE(env,
+                                 "second argument must be a string or object");
       return;
     }
 
diff --git a/test/parallel/test-urlpattern-types.js b/test/parallel/test-urlpattern-types.js
new file mode 100644
index 00000000000000..71133a7f6e48ac
--- /dev/null
+++ b/test/parallel/test-urlpattern-types.js
@@ -0,0 +1,46 @@
+'use strict';
+
+require('../common');
+
+const { URLPattern } = require('url');
+const { throws } = require('assert');
+
+// Verifies that calling URLPattern with no new keyword throws.
+throws(() => URLPattern(), {
+  code: 'ERR_CONSTRUCT_CALL_REQUIRED',
+});
+
+// Verifies that type checks are performed on the arguments.
+throws(() => new URLPattern(1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => new URLPattern({}, 1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => new URLPattern({}, '', 1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => new URLPattern({}, { ignoreCase: '' }), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+const pattern = new URLPattern();
+
+throws(() => pattern.exec(1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => pattern.exec('', 1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => pattern.test(1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+
+throws(() => pattern.test('', 1), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});