Skip to content

Commit

Permalink
build: gyp exclude libm linking on macOS
Browse files Browse the repository at this point in the history
PR-URL: #56901
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
  • Loading branch information
deepak1556 authored and nodejs-github-bot committed Feb 7, 2025
1 parent 756a242 commit b7ce941
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
7 changes: 4 additions & 3 deletions deps/brotli/brotli.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,15 @@
'defines': [
'OS_MACOSX'
]
}, {
'libraries': [
'-lm',
],
}],
],
'direct_dependent_settings': {
'include_dirs': [ 'c/include' ]
},
'libraries': [
'-lm',
],
'sources': [
'<@(brotli_sources)',
]
Expand Down
6 changes: 5 additions & 1 deletion deps/uv/uv.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@
'<@(uv_sources_posix)',
],
'link_settings': {
'libraries': [ '-lm' ],
'conditions': [
['OS=="solaris"', {
'ldflags': [ '-pthreads' ],
Expand All @@ -231,6 +230,11 @@
['OS != "solaris" and OS != "android" and OS != "zos"', {
'ldflags': [ '-pthread' ],
}],
['OS!="mac"', {
'libraries': [
'-lm'
],
}],
],
},
'conditions': [
Expand Down

0 comments on commit b7ce941

Please sign in to comment.