From 2a61c296a6f4f38c20039c704769ef9df41bb9a7 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Mon, 10 Feb 2025 14:10:18 -0500 Subject: [PATCH] test: update webstorage wpt PR-URL: https://github.com/nodejs/node/pull/56963 Reviewed-By: Colin Ihrig Reviewed-By: Filip Skokan Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Matthew Aitken Reviewed-By: Jason Zhang --- test/fixtures/wpt/README.md | 2 +- test/fixtures/wpt/versions.json | 2 +- ...age-about-blank-3P-iframe-opens-3P-window.partitioned.html} | 2 +- ...tative.sub.html => localstorage-basic-partitioned.sub.html} | 2 +- ...dow.js => localstorage-cross-origin-iframe.https.window.js} | 0 ...tive.sub.html => sessionStorage-basic-partitioned.sub.html} | 2 +- test/wpt/status/webstorage.json | 3 +++ 7 files changed, 8 insertions(+), 5 deletions(-) rename test/fixtures/wpt/webstorage/{localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html => localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html} (99%) rename test/fixtures/wpt/webstorage/{localstorage-basic-partitioned.tentative.sub.html => localstorage-basic-partitioned.sub.html} (97%) rename test/fixtures/wpt/webstorage/{localstorage-cross-origin-iframe.tentative.https.window.js => localstorage-cross-origin-iframe.https.window.js} (100%) rename test/fixtures/wpt/webstorage/{sessionStorage-basic-partitioned.tentative.sub.html => sessionStorage-basic-partitioned.sub.html} (97%) diff --git a/test/fixtures/wpt/README.md b/test/fixtures/wpt/README.md index 7b6b8c29ce3d12..c88edde07cdbd3 100644 --- a/test/fixtures/wpt/README.md +++ b/test/fixtures/wpt/README.md @@ -36,7 +36,7 @@ Last update: - WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/3e3374efde/WebCryptoAPI - webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions - webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel -- webstorage: https://github.com/web-platform-tests/wpt/tree/9dafa89214/webstorage +- webstorage: https://github.com/web-platform-tests/wpt/tree/1291340aaa/webstorage [Web Platform Tests]: https://github.com/web-platform-tests/wpt [`git node wpt`]: https://github.com/nodejs/node-core-utils/blob/main/docs/git-node.md#git-node-wpt diff --git a/test/fixtures/wpt/versions.json b/test/fixtures/wpt/versions.json index 5ac57c34db0ed5..3a93f2734a93d5 100644 --- a/test/fixtures/wpt/versions.json +++ b/test/fixtures/wpt/versions.json @@ -104,7 +104,7 @@ "path": "webmessaging/broadcastchannel" }, "webstorage": { - "commit": "9dafa892146c4b5b1f604a39b3cf8677f8f70d44", + "commit": "1291340aaaa6e73db43b412e47401eca3830c556", "path": "webstorage" } } diff --git a/test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html b/test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html similarity index 99% rename from test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html rename to test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html index a474a8c0de3746..de94fb2cf435de 100644 --- a/test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html +++ b/test/fixtures/wpt/webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html @@ -57,7 +57,7 @@ for (let id in ids) { assert_true(id !== undefined, "id is not undefined"); } - // Note: we use assert_true, rather than assert_equals because we're + // Note: we use assert_true, rather than assert_equals becuase we're // setting random numbers as IDs - this would mean expectations // files wouldn't work as intended. assert_true(crossSiteIframeAboutBlankID !== crossSiteIframeID, diff --git a/test/fixtures/wpt/webstorage/localstorage-basic-partitioned.tentative.sub.html b/test/fixtures/wpt/webstorage/localstorage-basic-partitioned.sub.html similarity index 97% rename from test/fixtures/wpt/webstorage/localstorage-basic-partitioned.tentative.sub.html rename to test/fixtures/wpt/webstorage/localstorage-basic-partitioned.sub.html index 7ed49b1e9a0eb5..3d5b1e93ce5ef6 100644 --- a/test/fixtures/wpt/webstorage/localstorage-basic-partitioned.tentative.sub.html +++ b/test/fixtures/wpt/webstorage/localstorage-basic-partitioned.sub.html @@ -38,7 +38,7 @@ assert_true(typeof sameSiteID === "string"); if (location.origin !== altOrigin) { - crossSiteWindow = window.open(`${altOrigin}/webstorage/localstorage-basic-partitioned.tentative.sub.html`, "", "noopener=false"); + crossSiteWindow = window.open(`${altOrigin}/webstorage/localstorage-basic-partitioned.sub.html`, "", "noopener=false"); t.add_cleanup(() => crossSiteWindow.close()); } } diff --git a/test/fixtures/wpt/webstorage/localstorage-cross-origin-iframe.tentative.https.window.js b/test/fixtures/wpt/webstorage/localstorage-cross-origin-iframe.https.window.js similarity index 100% rename from test/fixtures/wpt/webstorage/localstorage-cross-origin-iframe.tentative.https.window.js rename to test/fixtures/wpt/webstorage/localstorage-cross-origin-iframe.https.window.js diff --git a/test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.tentative.sub.html b/test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.sub.html similarity index 97% rename from test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.tentative.sub.html rename to test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.sub.html index 30575bfaf1a579..38525b99a23497 100644 --- a/test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.tentative.sub.html +++ b/test/fixtures/wpt/webstorage/sessionStorage-basic-partitioned.sub.html @@ -47,7 +47,7 @@ // new cross-site window that contains our shared-iframe to repeat // the process in a cross-site environment. if (location.origin !== altOrigin) { - crossSiteWindow = window.open(`${altOrigin}/webstorage/sessionStorage-basic-partitioned.tentative.sub.html`, "", "noopener=false"); + crossSiteWindow = window.open(`${altOrigin}/webstorage/sessionStorage-basic-partitioned.sub.html`, "", "noopener=false"); t.add_cleanup(() => crossSiteWindow.close()); } } diff --git a/test/wpt/status/webstorage.json b/test/wpt/status/webstorage.json index 4ecdb2721bd24b..10171601480aad 100644 --- a/test/wpt/status/webstorage.json +++ b/test/wpt/status/webstorage.json @@ -8,6 +8,9 @@ "localstorage-cross-origin-iframe.tentative.https.window.js": { "skip": "iframes are not supported in Node.js." }, + "localstorage-cross-origin-iframe.https.window.js": { + "skip": "iframes are not supported in Node.js." + }, "storage_local_window_open.window.js": { "skip": "window.open() is not supported in Node.js." },