Skip to content

Commit

Permalink
src: add missing handle scope to fast API
Browse files Browse the repository at this point in the history
V8 now requires it for `ArrayBufferView->Buffer()`.
  • Loading branch information
targos authored and nodejs-github-bot committed Feb 3, 2025
1 parent 336d379 commit 4cea17e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/node_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1477,6 +1477,7 @@ uint32_t FastWriteString(Local<Value> receiver,
uint32_t max_length,
// NOLINTNEXTLINE(runtime/references) This is V8 api.
v8::FastApiCallbackOptions& options) {
HandleScope handle_scope(options.isolate);
THROW_AND_RETURN_VAL_UNLESS_BUFFER(options.isolate, dst, "dst", 0);
SPREAD_BUFFER_ARG(dst, dst_buffer);
CHECK(dst_buffer_length <=
Expand Down

0 comments on commit 4cea17e

Please sign in to comment.