-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added monitor for release jenkins agents #262
Open
UlisesGascon
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
UlisesGascon:feat/add-release-jenkins-monitoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: "⚙️ Monitor Jenkins Release CI" | ||
| on: | ||
| schedule: | ||
| # Run every hour | ||
| - cron: "21 * * * *" | ||
|
|
||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: none | ||
| issues: write | ||
| packages: none | ||
|
|
||
| jobs: | ||
| security-scoring: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Jenkins Alert and Reporting | ||
| uses: UlisesGascon/jenkins-status-alerts-and-reporting@v1.3.0 | ||
| id: jenkins-status-alerts-and-reporting | ||
| with: | ||
| database: monitor-release/database.json | ||
| jenkins-domain: 'ci-release.nodejs.org' | ||
| jenkins-username: ${{ secrets.JENKINS_RELEASE_USERNAME }} | ||
| jenkins-token: ${{ secrets.JENKINS_RELEASE_TOKEN }} | ||
| # Issues | ||
| generate-issue: true | ||
| issue-assignees: 'UlisesGascon' | ||
| issue-labels: 'potential-incident,release-ci' | ||
| create-issues-for-new-offline-nodes: false | ||
| auto-close-issue: true | ||
| disk-alert-level: 90 | ||
| # Report | ||
| report: monitor-release/jenkins-report.md | ||
| report-tags-enabled: false | ||
| # Git changes | ||
| auto-commit: true | ||
| auto-push: true | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # - name: Print the Computers | ||
| # run: | | ||
| # echo '${{ steps.jenkins-status-alerts-and-reporting.outputs.computers }}' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardlau not sure if makes sense to assign the issues to me, as I can't access to that Jenkins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hoping that won't be the case for long 🙂.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What level of access does the token give to the release jenkins instance? Just want to understand what the potential security impact might be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhdawson AFAIK we currently do not have a token with access to the release Jenkins instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardlau right, but I think this would require one. I'm trying to understand what the risk of having a token with access to the release Jenkins in a public GitHub repo is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can limit the surface if we use read-only tokens. Not sure how much granularity (limit to compute) Jenkins offers currently for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how we can limit the tokens we might also want to have the actions run in a private repo?