Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce our code complexity #55

Closed
cclauss opened this issue Jul 14, 2020 · 1 comment
Closed

Reduce our code complexity #55

cclauss opened this issue Jul 14, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@cclauss
Copy link
Contributor

cclauss commented Jul 14, 2020

As discussed in #54 McCabe code complexity as measured by flake8 is at 101 when it should be more like 10.

The task here is to run flake8 --max-complexity=100 and ensure that the most complex functions have great test coverage and then refactor them to get their complexity score lower. Repeat this process with other complex functions by lowering the flake8 --max-complexity=xx value.
@cclauss cclauss mentioned this issue Jul 14, 2020
Merged
@targos targos added the good first issue Good for newcomers label Jul 14, 2020
@cclauss
Copy link
Contributor Author

cclauss commented Jun 22, 2021

Closing as a dup of #101

@cclauss cclauss closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @cclauss