fix: correct update script to support version argument again

[SimenB]

We keep getting key updates from the update script for unchanged node versions, even when the script passes e.g. ./update.sh 22. This is due to a regression in #1307 where the get_versions function no longer looked at its arguments for which version directories to load.

I also got ./update.sh: line 240: pids[@]: unbound variable, so I moved its declaration.

I also couldn't resist Object.keys() -> Object.entires() since we were accessing the values in the loop

---

This should remove the need for PRs such as #2151, as the script should just update the versions with an actual node version change:

docker-node/build-automation.mjs

Line 92 in ebd48c9

const { stdout } = await exec(`./update.sh ${newVersions[version].isSecurityRelease ? "-s " : ""}${version}`);

[SimenB]

I'm really bad as (ba)sh scripting, so there's probably a better solution to this. It works, tho - both with and without the version arguments

[SimenB]

Not sure how to get around the shellcheck violation. We do call it with arguments (from a different file)

docker-node/update.sh

Line 56 in ebd48c9

IFS=' ' read -ra update_versions <<< "$(get_versions . "${versions_arg[@]:-}")"

[SimenB]

@nodejs/docker PTAL

[PeterDaveHello]

I'll need a bit of time to go through this.

By the way, just wondering if we should consider using AI tools to assist with code reviews and suggestions? I've been trying out https://coderabbit.ai/ recently and found it quite helpful. It provides some valuable suggestions and even catches some errors. Could improve the efficiency for such a busy volunteer team like us 😆

Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (2)

• functions.sh: Language not supported
• update.sh: Language not supported