-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use temporary GNUPGHOME
directory when using gpg in image builds
#1901
Conversation
5008f2f
to
65d976a
Compare
Rebased onto I think a decision should be made to prefer either grouping all cleaning operations, or to stick with a 'clean as soon as possible' policy, to group related logic more tightly together. |
65d976a
to
72958a9
Compare
Rebased this onto |
@SimenB @PeterDaveHello any objection to merging this? |
None at all 😃 |
Created PR on the official-images repo (docker-library/official-images#15565). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
@@ -19,6 +19,9 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \ | |||
# libatomic1 for arm | |||
&& apt-get update && apt-get install -y ca-certificates curl wget gnupg dirmngr xz-utils libatomic1 --no-install-recommends \ | |||
&& rm -rf /var/lib/apt/lists/* \ | |||
# use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 | |||
&& export GNUPGHOME="$(mktemp -d)" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this variable doesn't need to be exported?
Description
As a follow-up to #1895 (comment), this PR alters the debian-based images to use a temporary
GNUPGHOME
directory to be more consistent with other official image and possibly prevent future issues with new GPG versions.Motivation and Context
Discussion on #1895.
Testing Details
Example Output(if appropriate)
Types of changes
Checklist