Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try only to PR files with NODE_VERSION change #1788

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nschonni
Copy link
Member

Don't think this actually will resolve it, but this diff command will limit it to only the files that have changed versions.
Proper solution probably needs some re-work that would require the migration from SH to JS for update.sh

@nschonni nschonni force-pushed the git-only-version-changes branch from a08af58 to 0eb9fa7 Compare October 12, 2022 18:49
@SimenB
Copy link
Member

SimenB commented Oct 25, 2022

Proper solution probably needs some re-work that would require the migration from SH to JS for update.sh

To the surprise of no one, this is my preferred solution 😃

Or, I'd prefer TS and ts-node or something. But migration to JS would be a great improvement to maintainability (we could do inline jsdoc which helps IDE integration without needing an installation and verification step)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants