Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS Node 18.18.1 is not supported (missing image in docker hub) #1974

Closed
mlandisbqs opened this issue Oct 11, 2023 · 3 comments · Fixed by #1975
Closed

LTS Node 18.18.1 is not supported (missing image in docker hub) #1974

mlandisbqs opened this issue Oct 11, 2023 · 3 comments · Fixed by #1975

Comments

@mlandisbqs
Copy link

mlandisbqs commented Oct 11, 2023

Environment

  • Platform: any
  • Docker Version: any
  • Node.js Version: 18.18.1
  • Image Tag: node:18.18.1-alpine

Expected Behavior

Our CI Pipeline validates that our software runs on LTS. When LTS changes we upgrade our packages. Part of the team's build process relies on the docker images for node being available for LTS with an assumption that LTS would be supported and promptly available in docker hub. We've never had an issue before but the build is breaking because this version has not been published.

Current Behavior

------
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: docker.io/library/node:18.18.1-alpine: not found

Possible Solution

When LTS is updated, a corresponding docker image should be promptly created.

Steps to Reproduce

# we run our docker compose command...
docker-compose --env-file .env.jenkins -f ./conf/docker/e2e/docker-compose.yml up --abort-on-container-exit --force-recreate --build

Additional Information

@SimenB
Copy link
Member

SimenB commented Oct 11, 2023

Yeah, bot isn't picking up the new version for some reason

https://github.com/nodejs/docker-node/actions/runs/6483642231

EDIT: Ah - There's no musl build for version 18.18.1 yet.. It's still building: https://unofficial-builds.nodejs.org/logs/202310111207-v18.18.1/

@mlandisbqs
Copy link
Author

mlandisbqs commented Oct 11, 2023

I've unblocked us this way - adding an extra check in our LTS check:

async function dockerHubHasLTS(nodeLtsVersion) {
  try {
    await axios.head(`https://hub.docker.com/v2/repositories/library/node/tags/${nodeLtsVersion}`);
  } catch (err) {
    return false;
  }
  return true;
}

@nschonni
Copy link
Member

with an assumption that LTS would be supported and promptly available in docker hub. We've never had an issue before but the build is breaking because this version has not been published.

That's not the case (and never has been). There is an automated PR to this repo that is then reviewed by the team, then once that merges, an automated PR to the upstream repo for the Docker hub, which also needs the PRs to be approved.

As @SimenB mentions above, we're waiting for the Unofficial builds to finish the ARM releases, then an automated PR will be created

@nschonni nschonni linked a pull request Oct 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants