Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parallelize linking, unlinking and installing #524

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat: parallelize linking, unlinking and installing #524

merged 3 commits into from
Jul 12, 2024

Conversation

wojtekmaj
Copy link
Contributor

An extended version of #500.

aduh95
aduh95 reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reduce the amount of time we iterate on the same values, and the number of time we run the same comparison

sources/commands/Disable.ts Outdated Show resolved Hide resolved
sources/commands/Disable.ts Outdated Show resolved Hide resolved
sources/commands/Disable.ts Outdated Show resolved Hide resolved
@aduh95 aduh95 enabled auto-merge (squash) July 12, 2024 12:41
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Closed
@aduh95 aduh95 merged commit f0734e6 into nodejs:main Jul 12, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
@wojtekmaj wojtekmaj deleted the link-unlink-concurrently branch July 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekmaj @aduh95