You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We do test with the latest version, I don't see the point for testing other versions but I guess I'm not opposed to it
Based on the realization that all versions of npm prior to npm@11.1.0 were signed with the same keyid (see Saveguards for keyid mismatch #616 (comment)) I also now don't see the advantage of testing additional versions. The proposed tests would only reveal the availability of the different versions. They would not exercise any different code in Corepack.
Issue
The currently active versions of npm
10.x
and11.x
are not tested in tests/main.test.ts.Corepack
Corepack tests/main.test.ts uses:
npm@6.14.2
corepack/tests/main.test.ts
Lines 129 to 131 in a7cb9f6
npm
11.x
version and lists legacy versions6.x
-10.x
latest
release (npm view npm version
).10.x
.Suggestion
Update tests/main.test.ts.
Consider adding legacy versions (corresponds to
next-x
tags):npm@7.24.2
npm@8.19.4
npm@9.9.4
Add currently supported versions:
npm@10.9.2
npm@11.1.0
The text was updated successfully, but these errors were encountered: