Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing npm 10.x & 11.x tests #622

Closed
MikeMcC399 opened this issue Feb 1, 2025 · 2 comments
Closed

Missing npm 10.x & 11.x tests #622

MikeMcC399 opened this issue Feb 1, 2025 · 2 comments

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 1, 2025

Issue

The currently active versions of npm 10.x and 11.x are not tested in tests/main.test.ts.

Corepack

Corepack tests/main.test.ts uses:

  • npm@6.14.2

corepack/tests/main.test.ts

Lines 129 to 131 in a7cb9f6

[`npm`, `6.14.2`],
[`npm`, `6.14.2+sha1.f057d35cd4792c4c511bb1fa332edb43143d07b0`],
[`npm`, `6.14.2+sha224.50512c1eb404900ee78586faa6d756b8d867ff46a328e6fb4cdf3a87`],

npm

Suggestion

Update tests/main.test.ts.

Consider adding legacy versions (corresponds to next-x tags):

  • npm@7.24.2
  • npm@8.19.4
  • npm@9.9.4

Add currently supported versions:

  • npm@10.9.2
  • npm@11.1.0
@aduh95
Copy link
Contributor

aduh95 commented Feb 1, 2025

We do test with the latest version, I don't see the point for testing other versions but I guess I'm not opposed to it

@MikeMcC399
Copy link
Contributor Author

@aduh95

We do test with the latest version, I don't see the point for testing other versions but I guess I'm not opposed to it

  • Based on the realization that all versions of npm prior to npm@11.1.0 were signed with the same keyid (see Saveguards for keyid mismatch #616 (comment)) I also now don't see the advantage of testing additional versions. The proposed tests would only reveal the availability of the different versions. They would not exercise any different code in Corepack.
  • Withdrawing this suggestion therefore.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants