Simplify getting allBinNames

nodejs · Jul 12, 2024 · 1cfa1f6 · 1cfa1f6
1 parent ccf56e9
commit 1cfa1f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/sources/commands/Disable.ts b/sources/commands/Disable.ts
@@ -50,18 +50,16 @@ export class DisableCommand extends Command<Context> {
       ? SupportedPackageManagerSetWithoutNpm
       : this.names;
 
-    const binNamesMap = new Map<string, Set<string>>();
+    const allBinNames: string[] = [];
 
     for (const name of new Set(names)) {
       if (!isSupportedPackageManager(name))
         throw new UsageError(`Invalid package manager name '${name}'`);
 
       const binNames = this.context.engine.getBinariesFor(name);
-      binNamesMap.set(name, binNames);
+      allBinNames.push(...binNames);
     }
 
-    const allBinNames = Array.from(binNamesMap.values()).flatMap(binNames => Array.from(binNames));
-
     await Promise.all(allBinNames.map(binName => {
       if (process.platform === `win32`) {
         return this.removeWin32Link(installDirectory, binName);

diff --git a/sources/commands/Enable.ts b/sources/commands/Enable.ts
@@ -60,18 +60,16 @@ export class EnableCommand extends Command<Context> {
       ? SupportedPackageManagerSetWithoutNpm
       : this.names;
 
-    const binNamesMap = new Map<string, Set<string>>();
+    const allBinNames: string[] = [];
 
     for (const name of new Set(names)) {
       if (!isSupportedPackageManager(name))
         throw new UsageError(`Invalid package manager name '${name}'`);
 
       const binNames = this.context.engine.getBinariesFor(name);
-      binNamesMap.set(name, binNames);
+      allBinNames.push(...binNames);
     }
 
-    const allBinNames = Array.from(binNamesMap.values()).flatMap(binNames => Array.from(binNames));
-
     await Promise.all(allBinNames.map(binName => {
       if (process.platform === `win32`) {
         return this.generateWin32Link(installDirectory, distFolder, binName);