Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send test post to verify that the automation works #8

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 1, 2024

Reopened from #5 from a branch in this repository, because turns out secrets are not available to workflows started from forks (duh). Will do a bit of follow-up to split the validation into full validation (validates bluesky URL references which requires secrets) + local validation (just that the JSON looks right, without requiring secrets) as mentioned in #5 (comment) but for now creating PRs from branches in this repo should be fine.

@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 1, 2024

cc @nodejs/tsc (sorry for the noise, I guess there's trial and error for everything for the first time! But the validation workflow looks happy enough ;))

@anonrig
Copy link
Member

anonrig commented Dec 1, 2024

🚀

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyeecheung joyeecheung merged commit 47aa614 into main Dec 2, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Dec 2, 2024
@joyeecheung
Copy link
Member Author

For posterity, it works: https://bsky.app/profile/nodejs.org/post/3lcd5ct56w42m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants