Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for single query splunk ratio SLOs [PC-13052] #375

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

dawidwisn
Copy link
Contributor

@dawidwisn dawidwisn commented Jan 2, 2025

Motivation

Support for single query splunk ratio SLOs

Summary

Example:

  objective {
    display_name = "obj1"
    name         = "tf-objective-1"
    primary      = false
    target       = 0.7
    time_slice_target = 0
    value        = 1
    count_metrics {
      incremental = true
      good_total {
		splunk {
		  query = "| mstats avg(\"spl.intr.resource_usage.IOWait.data.avg_cpu_pct\") as n9good WHERE index=\"_metrics\" span=15s | join type=left _time [ | mstats avg(\"spl.intr.resource_usage.IOWait.data.max_cpus_pct\") as n9total WHERE index=\"_metrics\" span=15s] | rename _time as n9time | fields n9time n9good n9total"
		}
      }
    }
  }

Release Notes

Support for single query splunk ratio SLOs

@n9-machine-user n9-machine-user added the go Pull requests that update Go code label Jan 2, 2025
@dawidwisn dawidwisn changed the title PC-13052 Support for single query splunk ratio SLOs feat: Support for single query splunk ratio SLOs [PC-13052] Jan 2, 2025
@n9-machine-user n9-machine-user added enhancement New feature or request minor New functionality with at most minor breaking changes labels Jan 2, 2025
@dawidwisn dawidwisn marked this pull request as ready for review January 8, 2025 12:24
marcinlawnik
marcinlawnik previously approved these changes Jan 21, 2025
@paulina-n9
Copy link
Contributor

lgtm 👌

@paulina-n9 paulina-n9 added the passed-testing Added by QA when tests have passed label Jan 22, 2025
Co-authored-by: paulina-n9 <65724378+paulina-n9@users.noreply.github.com>
@dawidwisn dawidwisn enabled auto-merge (squash) January 22, 2025 12:06
@dawidwisn dawidwisn merged commit dbd8c5a into main Jan 22, 2025
5 checks passed
@dawidwisn dawidwisn deleted the PC-13052-support-for-single-query-splunk-ratio-SLOs branch January 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code minor New functionality with at most minor breaking changes passed-testing Added by QA when tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants