fix: Correct version handling for Terraform Plugin Framework and fix acceptance tests #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz,
daniel-zelazny and
BSski
as code owners
n9-machine-user
added
bug
…/terraform-provider-nobl9 into fix-version-handling-and-acc-tests
BSski
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After merging #351 the acceptance tests started failing.
This was due to the fact that Service resource was no longer defined in the old provider, and since the tests were not utilizing the provider multiplexer, the Service resource was effectively undefined.
Summary
Versionvariable was moved tomain.go.idattribute creation in Terraform SDK v2 and and this error being dropped in old tests, I had to switch old tests to the new terraform-plugin-testing library. Both new and old libraries' APIs were almost identical, so the conversion was seamless, just import changes.Testing
Run
make test/accwith valid Nobl9 credentials.