-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PC-14787 Enable specifying project in the command for importing #354
Open
BSski
wants to merge
9
commits into
main
Choose a base branch
from
PC-14787-enable-specifying-project-in-tf-import-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7831874
PC-14787 Enable specifying project in TF import command
BSski 6193c13
PC-14787 Fix too long line in README.md
BSski 9ac41cb
PC-14787 Add docs
BSski 35659e9
PC-14787 Fix lint: param type combine
BSski 8e2c902
Update templates/index.md.tmpl
BSski 2bf8e5c
Update docs/index.md
BSski c35afe7
Merge branch 'main' into PC-14787-enable-specifying-project-in-tf-imp…
BSski 477dfc3
Merge branch 'PC-14787-enable-specifying-project-in-tf-import-command…
BSski ac8a0d7
PC-14787 Fix typo
BSski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ func resourceSLO() *schema.Resource { | |
DeleteContext: resourceSLODelete, | ||
ReadContext: resourceSLORead, | ||
Importer: &schema.ResourceImporter{ | ||
StateContext: schema.ImportStatePassthroughContext, | ||
StateContext: resourceSLOImport, | ||
}, | ||
Description: "[SLO configuration documentation](https://docs.nobl9.com/yaml-guide#slo)", | ||
} | ||
|
@@ -456,6 +456,17 @@ func resourceSLODelete(ctx context.Context, d *schema.ResourceData, meta interfa | |
return nil | ||
} | ||
|
||
func resourceSLOImport(_ context.Context, d *schema.ResourceData, _ interface{}) ([]*schema.ResourceData, error) { | ||
project, resourceID := parseImportID(d.Id()) | ||
if project != "" { | ||
if err := d.Set("project", project); err != nil { | ||
return nil, fmt.Errorf("error setting project: %w", err) | ||
} | ||
} | ||
d.SetId(resourceID) | ||
return []*schema.ResourceData{d}, nil | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. placeholder comment: why we're not adding acceptance tests for import? |
||
func schemaMetricSpec() *schema.Resource { | ||
metricSchemaDefinitions := []map[string]*schema.Schema{ | ||
schemaMetricAmazonPrometheus(), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what If project is empty? will it eventually use the default project? just asking