Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-12014 Support CompositesV2 #194

Merged
merged 30 commits into from
Apr 12, 2024

Conversation

BSski
Copy link
Contributor

@BSski BSski commented Mar 8, 2024

Summary

Deprecated the composite section on top-level SLO resource and replaced it with objective level composite definition.
Besides the composite related changes, this PR makes indicator field optional, as the provider wasn't allowing applying composite SLOs which do not use it.
The changes are not yet available for our users, therefore no release note included.

@n9-machine-user n9-machine-user added breaking-change Any kind of non-backwards compatible change go Pull requests that update Go code release-notes labels Mar 8, 2024
@nieomylnieja nieomylnieja removed breaking-change Any kind of non-backwards compatible change release-notes labels Mar 11, 2024
@n9-machine-user n9-machine-user added the breaking-change Any kind of non-backwards compatible change label Mar 15, 2024
@BSski BSski changed the title PC-12014 Support Composites V2 in Terraform Provider feat: PC-12014 Support Composites V2 in Terraform Provider Mar 15, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor New functionality with at most minor breaking changes labels Mar 15, 2024
@BSski BSski removed the breaking-change Any kind of non-backwards compatible change label Mar 15, 2024
@n9-machine-user n9-machine-user added the breaking-change Any kind of non-backwards compatible change label Mar 26, 2024
@BSski BSski removed the breaking-change Any kind of non-backwards compatible change label Mar 26, 2024
@BSski BSski changed the title feat: PC-12014 Support Composites V2 in Terraform Provider feat: PC-12014 Support CompositesV2 in Terraform Provider Mar 26, 2024
@n9-machine-user n9-machine-user added the breaking-change Any kind of non-backwards compatible change label Mar 26, 2024
@BSski BSski removed the breaking-change Any kind of non-backwards compatible change label Mar 27, 2024
@n9-machine-user n9-machine-user added the breaking-change Any kind of non-backwards compatible change label Apr 2, 2024
@BSski BSski removed the breaking-change Any kind of non-backwards compatible change label Apr 3, 2024
@BSski BSski requested a review from daniel-zelazny as a code owner April 3, 2024 09:49
@BSski BSski requested a review from nikodemrafalski April 3, 2024 09:49
@nikodemrafalski
Copy link
Contributor

As per today's reminder of tech writing team, please add more context to the release notes - for example:
We deprecated the composite section on top-level SLO resource and replace it with objective level composite definition

@nikodemrafalski
Copy link
Contributor

The documentation needs to be regenerated with make generate and committed. Also, just double-checking, have the documentation changes been reviewed by the tech writing team?

nobl9/resource_slo.go Outdated Show resolved Hide resolved
nobl9/resource_slo.go Outdated Show resolved Hide resolved
@annatrifonova
Copy link

Findings after the 1st round of tests:

  1. Objective's display_name is required now - should be optional (this is not related to the changes made for composites, but after discussion with Bartek decided to fix it here)
  2. composite block cannot be applied without objectives and components - they should be optional (same as in sloctl)
  3. objectives block cannot be empty (now terraform provider is craching when it's empty) - objectives should be optional

@annatrifonova annatrifonova added the passed-testing Added by QA when tests have passed label Apr 10, 2024
@BSski BSski requested a review from nikodemrafalski April 10, 2024 17:47
@nikodemrafalski nikodemrafalski changed the title feat: PC-12014 Support CompositesV2 in Terraform Provider feat: PC-12014 Support CompositesV2 Apr 11, 2024
@BSski BSski merged commit 3f72ccf into main Apr 12, 2024
5 checks passed
@BSski BSski deleted the pc-12014-support-composite-2.0-in-terraform branch April 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code minor New functionality with at most minor breaking changes passed-testing Added by QA when tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants