-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaked proxy_execute_jsc_get_proxies_for_url() if exception raised #86
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 54 54
Lines 4883 4888 +5
Branches 1116 1118 +2
=======================================
+ Hits 2895 2898 +3
- Misses 1359 1360 +1
- Partials 629 630 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
97f378f
to
1a89db3
Compare
Removed usages of |
@@ -235,6 +239,11 @@ void proxy_execute_jsc_delayed_init(void) { | |||
if (!g_proxy_execute_jsc.module) | |||
return; | |||
|
|||
// GObject functions (loaded as a dependency of the module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to do this in JavaScriptCore one? Load it as a dependency of the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JavaScriptCore uses JSGlobalContextRelease()
.
1a89db3
to
a88e5f8
Compare
No description provided.