Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaked proxy_execute_jsc_get_proxies_for_url() if exception raised #86

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sergio-nsk
Copy link
Collaborator

No description provided.

@sergio-nsk sergio-nsk added bug Something isn't working cleanup Housekeeping tasks labels Jan 8, 2025
@sergio-nsk sergio-nsk requested a review from nmoinvaz January 8, 2025 18:32
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.28%. Comparing base (566dd35) to head (a88e5f8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
execute_jsc.c 50.00% 1 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files          54       54           
  Lines        4883     4888    +5     
  Branches     1116     1118    +2     
=======================================
+ Hits         2895     2898    +3     
- Misses       1359     1360    +1     
- Partials      629      630    +1     
Flag Coverage Δ
macos 55.87% <ø> (+0.11%) ⬆️
ubuntu 55.30% <50.00%> (+<0.01%) ⬆️
ubuntu_curl 57.34% <50.00%> (-0.04%) ⬇️
windows 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergio-nsk sergio-nsk force-pushed the sergio-nsk/jscore/2 branch from 97f378f to 1a89db3 Compare January 8, 2025 20:01
@sergio-nsk sergio-nsk removed the cleanup Housekeeping tasks label Jan 8, 2025
@sergio-nsk
Copy link
Collaborator Author

sergio-nsk commented Jan 8, 2025

Removed usages of g_clean_object because this is a macro calling two functions g_clear_pointer() and g_object_unref(). I don't want to dlsym(module, "g_clear_pointer") and redefine the macro for calling the dynamically bound functions.

@@ -235,6 +239,11 @@ void proxy_execute_jsc_delayed_init(void) {
if (!g_proxy_execute_jsc.module)
return;

// GObject functions (loaded as a dependency of the module)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to do this in JavaScriptCore one? Load it as a dependency of the module?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScriptCore uses JSGlobalContextRelease().

@sergio-nsk sergio-nsk force-pushed the sergio-nsk/jscore/2 branch from 1a89db3 to a88e5f8 Compare January 8, 2025 20:32
@nmoinvaz nmoinvaz merged commit 434a11d into master Jan 8, 2025
21 of 22 checks passed
@nmoinvaz nmoinvaz deleted the sergio-nsk/jscore/2 branch January 8, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants