-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate separate objects for cu and nvrtc #119
Conversation
We are not sure if this is what we need as #96 is suggesting something else. |
@@ -20,6 +20,8 @@ set(SOURCE_FILES src/cu.cpp src/nvrtc.cpp) | |||
include_directories(./include/) | |||
include_directories(${CUDAToolkit_INCLUDE_DIRS}) | |||
|
|||
add_library(cudawrappers_cu SHARED src/cu.cpp) | |||
add_library(cudawrappers_nvrtc SHARED src/nvrtc.cpp) | |||
add_library(cudawrappers SHARED ${SOURCE_FILES}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to build libcudawrappers.so
from source, you could just link all the libcudawrappers_*.so
files together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understood no, the .so
does not have the necessary information to be merged or linked in another .so
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider the use of CMake object libraries. You can make object libraries for cudawrappers_cu
and cudawrappers_nvrt
and link these into the final libcudawrappers_cu.so
and libcudawrappers_nvrtc.so
, as well as libcudawrappers.so
.
I think we need to make this more clear before we do more work. |
Superseded by #150 |
Description
Generate separate objects for cu and nvrtc. Namely
libcudawrappers_cu.so
andlibcudawrappers_nvrtc.so
.Related issues:
Instructions to review the pull request
Clone and verify
build
for the.so
files.