From f849b1f9aeeda7f2fe1ffc6d481e3230e68e769a Mon Sep 17 00:00:00 2001 From: Nick Junius Date: Thu, 5 May 2022 17:39:26 -0700 Subject: [PATCH] refactored get_possible_affects get_possible_affects no longer uses a pointless continue and should be more readable now --- src/core/affecter.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/core/affecter.py b/src/core/affecter.py index 0a41a39..0d8622e 100644 --- a/src/core/affecter.py +++ b/src/core/affecter.py @@ -80,15 +80,14 @@ def get_possible_affects(self, affect_vector, allowable_error = 0.00000001): if not prevailing_affects: prevailing_affects.append(current_affect) - continue - - highest_value_seen = affect_vector[prevailing_affects[0]] - - if highest_value_seen < current_affect_value: - prevailing_affects = [] - prevailing_affects.append(current_affect) - elif abs(highest_value_seen - current_affect_value) < allowable_error: - prevailing_affects.append(current_affect) + else: + highest_value_seen = affect_vector[prevailing_affects[0]] + + if highest_value_seen < current_affect_value: + prevailing_affects = [] + prevailing_affects.append(current_affect) + elif abs(highest_value_seen - current_affect_value) < allowable_error: + prevailing_affects.append(current_affect) return prevailing_affects