refactored get_possible_affects

get_possible_affects no longer uses a pointless continue and should be more readable now
njunius · May 6, 2022 · f849b1f · f849b1f
1 parent 2e5ceaa
commit f849b1f
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/core/affecter.py b/src/core/affecter.py
@@ -80,15 +80,14 @@ def get_possible_affects(self, affect_vector, allowable_error = 0.00000001):
 
             if not prevailing_affects:
                 prevailing_affects.append(current_affect)
-                continue
-
-            highest_value_seen = affect_vector[prevailing_affects[0]]
-
-            if highest_value_seen < current_affect_value:
-                prevailing_affects = []
-                prevailing_affects.append(current_affect)
-            elif abs(highest_value_seen - current_affect_value) < allowable_error:
-                prevailing_affects.append(current_affect)
+            else:
+                highest_value_seen = affect_vector[prevailing_affects[0]]
+
+                if highest_value_seen < current_affect_value:
+                    prevailing_affects = []
+                    prevailing_affects.append(current_affect)
+                elif abs(highest_value_seen - current_affect_value) < allowable_error:
+                    prevailing_affects.append(current_affect)
 
         return prevailing_affects