comfyui won't build with rocm, due to broken python3.12-torch-2.5.1

[AshleyYakeley]

I set:

acceleration = "rocm";
rocmOverrideGfx = "10.3.0";

I get this during evaluation:

error: Package ‘python3.12-torch-2.5.1’ in /nix/store/p6ccgjymrlv4wwnxkx9hbhz0rbd5mnlr-source/pkgs/development/python-modules/torch/default.nix:691 is marked as broken, refusing to evaluate.

[MatthewCroughan]

As highlighted in the README.md:

If you think you can fix it via overlays and more, then please make a PR and I can test and merge it :D

[AshleyYakeley]

Do you know why python3.12-torch-2.5.1 has been marked broken?

[MatthewCroughan]

Yes, because there is not enough time or resources in Nixpkgs to maintain ROCM, so any fixes you find should be contributed there, and-or applied in an overlay here. In general ROCM stuff is pretty poorly supported in many distributions since AMD is also seemingly not very deeply invested in making things work properly, and attempts to make AMD GPUs work with CUDA get taken down https://www.phoronix.com/news/AMD-ZLUDA-CUDA-Taken-Down

[AshleyYakeley]

Hmm, ROCM seems to work fine with the ollama in nixpkgs. Or does that not use PyTorch?

[AshleyYakeley]

Tracking issue: NixOS/nixpkgs#197885