Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] mergify can't rebase "random" user's PRs #1793

Closed
MattSturgeon opened this issue Jul 1, 2024 · 0 comments · Fixed by #1809
Closed

[BUG] mergify can't rebase "random" user's PRs #1793

MattSturgeon opened this issue Jul 1, 2024 · 0 comments · Fixed by #1809
Labels
bug Something isn't working

Comments

@MattSturgeon
Copy link
Member

MattSturgeon commented Jul 1, 2024

Description

Apparently it is deprecated, and we should use the update_bot_account option:

For the queue action, public repositories accepting pull requests from users outside their organization must set a update_bot_account

Looking at the docs for update_bot_account:

For rebasing branches, Mergify might have to impersonate a GitHub user. You can specify the account to use with this option.
If no update_bot_account is set, Mergify uses the author of the PR. The user account must have already been logged in Mergify dashboard once.
For update_method: merge this option will be ignored in order for Mergify to not reset the merge queue, because of the merge commit done has a person instead of a bot.

I don't know if there is a way to continue using the PR author, unless they are not an org-member?

Since it's a template type maybe there's a way we can do this with a template expression?

Example

https://github.com/nix-community/nixvim/pull/1785/checks?check_run_id=26906365350

Upstream

Issue: Mergifyio/mergify#5075
Discussion: Mergifyio/mergify#5117

@MattSturgeon MattSturgeon added the bug Something isn't working label Jul 1, 2024
MattSturgeon added a commit to MattSturgeon/nixvim that referenced this issue Jul 4, 2024
@mergify mergify bot closed this as completed in 4730563 Jul 5, 2024
nfelber pushed a commit to nfelber/nixvim that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant