Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend name function to converter #31

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: extend name function to converter #31

merged 2 commits into from
Sep 12, 2024

Conversation

nrwiersma
Copy link
Contributor

Goal of this PR

This extends the name function to the converter, so they can match on naming.

Misc

  • PR title is explicit
  • PR includes unit tests for the added code / regression tests for the fixed bugs
  • PR is against the correct branch (likely main)
  • PR is linked to an issue

@nrwiersma nrwiersma requested a review from Ullaakut September 12, 2024 07:13
@nrwiersma nrwiersma self-assigned this Sep 12, 2024
Ullaakut
Ullaakut reviewed Sep 12, 2024
View reviewed changes
convert.go Outdated Show resolved Hide resolved
@nrwiersma nrwiersma merged commit 6c0f34c into nitrado:main Sep 12, 2024
2 checks passed
@nrwiersma nrwiersma deleted the name-func branch January 27, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

Assignees

@nrwiersma nrwiersma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrwiersma @Ullaakut