Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pointer conversions #26

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: pointer conversions #26

merged 1 commit into from
Jun 20, 2024

Conversation

nrwiersma
Copy link
Contributor

Goal of this PR

This fixes an issue where pointers to converted types is sometimes not picked out correctly.

Checklist

Does the PR require tests to be added or updated?

Tests are added.

Misc

  • PR title is explicit
  • PR includes unit tests for the added code / regression tests for the fixed bugs
  • PR is against the correct branch (likely main)
  • PR is linked to an issue

@nrwiersma nrwiersma self-assigned this Jun 20, 2024
@nrwiersma nrwiersma requested a review from antiphp June 20, 2024 09:40
@nrwiersma nrwiersma merged commit 9837f89 into nitrado:main Jun 20, 2024
2 checks passed
@nrwiersma nrwiersma deleted the fix-ptr-conversions branch June 20, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiphp antiphp antiphp approved these changes

Assignees

@nrwiersma nrwiersma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrwiersma @antiphp