Skip to content

Commit

Permalink
Fix github-build failure
Browse files Browse the repository at this point in the history
  • Loading branch information
nirbar committed Nov 21, 2023
1 parent cf0ede6 commit 488353e
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ jobs:
RuntimeTestsEnabled: true
SigningVaultUri: ${{ github.ref == 'refs/heads/master' && secrets.WIX_SIGNING_VAULTURI || '' }}
SigningCertName: ${{ github.ref == 'refs/heads/master' && secrets.WIX_SIGNING_CERTNAME || '' }}
BuildRunNumber: ${{ github.run_number }}

- name: Resolve build version
if: always()
Expand Down
1 change: 1 addition & 0 deletions src/Directory.csproj.targets
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<CreateDocumentation Condition=" '$(CreateDocumentationFile)'!='true' ">false</CreateDocumentation>
<DocumentationFile Condition=" '$(CreateDocumentationFile)'=='true' ">$(OutputPath)\$(AssemblyName).xml</DocumentationFile>
<DefineConstants Condition=" '$(Configuration)'=='Debug' ">$(DefineConstants);DEBUG</DefineConstants>
<SelfContained Condition=" '$(SelfContained)'=='' And '$(RuntimeIdentifier)' != '' ">true</SelfContained>

<WixVersionThisAssemblyFile>$(RootBuildFolder)ThisAssembly.WixVer.cs</WixVersionThisAssemblyFile>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<IsWixTestProject>true</IsWixTestProject>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<AssemblyName>Example.FullFramework2MBA</AssemblyName>
<RootNamespace>Example.FullFramework2MBA</RootNamespace>
<DebugType>embedded</DebugType>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions src/internal/SetBuildNumber/Directory.Packages.props.pp
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@
</ItemGroup>

<ItemGroup>
<PackageVersion Include="NuGet.Credentials" Version="6.3.1" />
<PackageVersion Include="NuGet.Protocol" Version="6.3.1" />
<PackageVersion Include="NuGet.Versioning" Version="6.3.1" />
<PackageVersion Include="NuGet.Credentials" Version="6.7.0" />
<PackageVersion Include="NuGet.Protocol" Version="6.7.0" />
<PackageVersion Include="NuGet.Versioning" Version="6.7.0" />
</ItemGroup>

<!--
Expand Down
1 change: 1 addition & 0 deletions src/test/burn/TestBA/TestBA.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<AssemblyName>TestBA</AssemblyName>
<RootNamespace>WixToolset.Test.BA</RootNamespace>
<DebugType>embedded</DebugType>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<EnableDynamicLoading>true</EnableDynamicLoading>
<UseWindowsForms>true</UseWindowsForms>
Expand Down
1 change: 1 addition & 0 deletions src/test/burn/TestBA/TestBA_x64.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<AssemblyName>TestBA</AssemblyName>
<RootNamespace>WixToolset.Test.BA</RootNamespace>
<DebugType>embedded</DebugType>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<EnableDynamicLoading>true</EnableDynamicLoading>
<UseWindowsForms>true</UseWindowsForms>
Expand Down
3 changes: 2 additions & 1 deletion src/test/burn/WixToolset.WixBA/WixToolset.WixBA.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<AssemblyName>WixToolset.WixBA</AssemblyName>
<RootNamespace>WixToolset.WixBA</RootNamespace>
<DebugType>embedded</DebugType>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<AssemblyTitle>WixToolset.WixBA</AssemblyTitle>
<Description>WiX Bootstrapper Application</Description>
Expand Down Expand Up @@ -41,4 +42,4 @@
<ItemGroup Condition=" '$(TargetFrameworkIdentifier)'!='.NETFramework' ">
<PackageReference Include="PanelSwWix4.Dnc.HostGenerator" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion src/test/burn/WixToolset.WixBA/WixToolset.WixBA_x64.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<AssemblyName>WixToolset.WixBA</AssemblyName>
<RootNamespace>WixToolset.WixBA</RootNamespace>
<DebugType>embedded</DebugType>
<SelfContained>true</SelfContained>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<AssemblyTitle>WixToolset.WixBA</AssemblyTitle>
<Description>WiX Bootstrapper Application</Description>
Expand Down Expand Up @@ -41,4 +42,4 @@
<ItemGroup Condition=" '$(TargetFrameworkIdentifier)'!='.NETFramework' ">
<PackageReference Include="PanelSwWix4.Dnc.HostGenerator" />
</ItemGroup>
</Project>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<SelfContained>true</SelfContained>
<RequiresNativeWixAssets>true</RequiresNativeWixAssets>
<IsWixTestProject>true</IsWixTestProject>
</PropertyGroup>
Expand Down

0 comments on commit 488353e

Please sign in to comment.