Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-word/special characters from B0FieldIdentifier/Source tags #437

Closed

Conversation

marcelzwiers
Copy link
Contributor

Using e.g. <<sesmri02>> as a B0FieldIdentifier (which is a perfectly valid thing to do) leads to a nipype invalid node name error:

image

This PR replaces the special characters, such as '<and>with-`

@marcelzwiers
Copy link
Contributor Author

This PR avoids errors from here: https://github.com/nipy/nipype/blob/master/nipype/pipeline/engine/base.py#L50

But perhaps it is better to filter out the special characters a bit later, e.g. in niworkflows, or even in nipype itself

@marcelzwiers
Copy link
Contributor Author

Oops, I now noticed PR #434, which looks like it may have already solved this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant