Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev instructions to use pnpm #20

Merged

Conversation

IonianPlayboy
Copy link
Collaborator

@IonianPlayboy IonianPlayboy commented Nov 24, 2024

A possible fix for #19, alternative to #21

If that's the direction we want to take, we can maybe uninstall @antfu/ni altogether from the project. I was not sure if it would break something so I did not touch it in this PR for now.

@prazdevs
Copy link
Member

Not sure we should remove ni, nor push away from it. See #19 (comment)

@IonianPlayboy
Copy link
Collaborator Author

Closed in favor of #21

@IonianPlayboy
Copy link
Collaborator Author

IonianPlayboy commented Nov 24, 2024

After the discussion in #19, I have reopened this PR and will close #21 in favor of this one.

@IonianPlayboy IonianPlayboy force-pushed the update-dev-instructions-pnpm branch from c473df0 to c0ce0d7 Compare November 24, 2024 23:52
Copy link
Contributor

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing up! It's clearer and less confusing now.

@patak-dev patak-dev merged commit 717d071 into nimbus-town:main Nov 25, 2024
2 checks passed
@IonianPlayboy IonianPlayboy deleted the update-dev-instructions-pnpm branch November 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants