fix compiler crash with .global initializers
#1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix the compiler crashing for initializers of `.global` variables where the expression contains locals or temporaries requiring destruction. Details ======= MIR generation for `.global` init fragments is done via `mirgen.generateAssignment`, which didn't push a scope prior to translation. This caused any call to `mirgen_blocks.register` to crash the compiler, as the scope/block list was empty. A scope is now pushed prior to translating the expression, fixing the crash. In addition to fixing the crash, this slightly changes behaviour: unscoped temporaries/locals created as part of a `.global` initializer are now destroyed immediately after the initialization, instead of at the end of the module's pre-init procedure. Destruction order w.r.t. `.global` initializers is unspecified, so this change shouldn't be a problem.
zerbina
added
bug
saem
approved these changes
Dec 5, 2024
|
@zerbina can you rebase this? |
|
/merge |
|
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the compiler crashing for initializers of
.globalvariables wherethe expression contains locals or temporaries requiring destruction.
Fixes #1470.
Details
MIR generation for
.globalinit fragments is done viamirgen.generateAssignment, which didn't push a scope prior totranslation. This caused any call to
mirgen_blocks.registerto crashthe compiler, as the scope/block list was empty.
A scope is now pushed prior to translating the expression, fixing the
crash. In addition to fixing the crash, this slightly changes
behaviour: unscoped temporaries/locals created as part of a
.globalinitializer are now destroyed immediately after the initialization,
instead of at the end of the module's pre-init procedure. Destruction
order w.r.t.
.globalinitializers is unspecified, so this changeshouldn't be a problem.