Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix destructors not being properly executed for fields within case
objects when changing the active branch, and using the JS backend.
Details
The destructor produced by
produceDestructorForDiscriminator
took areference to the discriminant field and used pointer arithmetic to
compute the address of the enclosing object. Not only is this
unnecessarily complex, it also doesn't work with the JS backend.
Instead, the destructor now takes a mutable reference to the
discriminant field's enclosing object type -- the MIR emitted for the
call is adjusted accordingly.
Since the destructor definitely modifies the object,
ekMutate
is usedinstead of
ekInvalidate
for the parameter passing. This results in asmall move analyzer regression:
Finally, a test is added for ensuring proper destruction when changing
the active branch.