Table add missing sink

[arnetheduck]

Description

Table should not need to copy its key argument during insertion:

import std/tables
type NoCopies = object

proc `=copy`(a: var NoCopies, b: NoCopies) {.error.}

var t: Table[NoCopies, NoCopies]
t[NoCopies()] = NoCopies() # only moves

The same probably holds for a lot of std lib containers, ie the concept applies to all of them.

Nim Version

2.2

Current Output

Error: '=copy' is not available for type <NoCopies>; requires a copy because it's not the last read of 'key'; try to make key a 'sink' parameter; routine: rawInsert

Expected Output

Known Workarounds

No response

Additional Information

No response

[Araq]

Ping @demotomohiro please work on this.

[ringabout]

I will take over it since it is similar to #24720 which lacks corresponding lent and sink in the stdlibs

[arnetheduck]

Same for toTable

[arnetheduck]

import std/tables
type NoCopies = object

proc `=copy`(a: var NoCopies, b: NoCopies) {.error.}

var t = {NoCopies(): NoCopies()}.toTable()

[ringabout]

toTable accepts opennArray, which is not to be sunk. Because openArray, which is a view type, doesn't own it data. But sink requires owning the data so it can destroy the data there. I'm not sure whether to make it work or detect it at the compile time