feat: allow chunkwise training and limit the number of processes for AFHMM+SAC #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levaphenyl
force-pushed
the
NILMTK-CONTRIB-36
branch
from
c8903ad to
be8c383
Compare
levaphenyl
changed the title
This was referenced Oct 7, 2020
levaphenyl
force-pushed
the
NILMTK-CONTRIB-36
branch
2 times, most recently
from
59e919e to
c0e8ad2
Compare
levaphenyl
force-pushed
the
NILMTK-CONTRIB-36
branch
from
c0e8ad2 to
2326bce
Compare
…the constraints setup and the actual minimization
levaphenyl
force-pushed
the
NILMTK-CONTRIB-36
branch
from
2326bce to
a0610f4
Compare
|
Having a quick scan through the code, this seems reasonably complete. Any blockers for merging? |
|
@jonnor - Thank you for your interest! The only blocker is to prove that the new code works as well as the former one. Unfortunately, I don't have time to test it these days. Would you like to try on your machine and report, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36
Fixes: #40
Fixes: #42
Fixes: #27
Tested on UK-DALE.
TODO: dev-test both AFHMM & AFHMM+SAC