You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 20, 2022. It is now read-only.
In the uvtee example, uv_pipe_open(&file_pipe, fd) fails on windows because internally it calls uv_set_pipe_handle which only works on something that is actually a named pipe. Should I open an issue at libuv instead? I'm not sure how to fix it.
I'm similarly not certain the example is fully functional on Linux either. Treating a pipe as a file isn't always valid. For example:
Thanks for bringing this up! I think the code in the book should have a check for the pipe-ness of the pipe. The fix itself will have to be upstream. I'd love a patch for the example.
I don't have a patch for the example, only for libuv on linux (although not high performant). I was pointing out that the statement in http://nikhilm.github.io/uvbook/filesystem.html#buffers-and-streams "This allows streaming local files [2]." is incorrect given libuv's current implementation on both the linux and windows operating systems -- specifically uv_pipe_open(&file_pipe, fd); fails or will cause libuv to abort().
In the uvtee example,
uv_pipe_open(&file_pipe, fd)
fails on windows because internally it callsuv_set_pipe_handle
which only works on something that is actually a named pipe. Should I open an issue at libuv instead? I'm not sure how to fix it.I'm similarly not certain the example is fully functional on Linux either. Treating a pipe as a file isn't always valid. For example:
I have a hack that fixes this issue, I'm wondering if you think I should also submit this fix upstream?
Thanks for the manual!
The text was updated successfully, but these errors were encountered: