Use a browser to load the page #481
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix lints chore: fix lints
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @IMXEren - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟡 Security: 1 issue found
- 🟡 Testing: 8 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Pretty big PR. I'm unfamiliar with the headless browser too. So, I'm not sure I'll be able to maintain, in case any issue occurs. I'll mark the PR as draft for now. Unless i get confident that I can maintain it myself. Plus docker image size difference is huge. |
|
It's alright. |
It's unnecessary to setup dependencies again & again, rather raise `ValueError`.
Repository owner
deleted a comment from
IMXEren
Apr 13, 2024
Repository owner
deleted a comment from
IMXEren
Apr 13, 2024
Repository owner
deleted a comment from
IMXEren
Apr 13, 2024
Repository owner
deleted a comment from
IMXEren
Apr 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think about this...
Fixes #375
There is a possible disadvantage for local docker users, i.e. the uncompressed size is 3x times (1.47 GB) of the current image (500 MB). I suppose offerring this feature as another tag can be a good option.