Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: More granular colour selectors #286

Open
No1InParticular opened this issue Jan 28, 2025 · 1 comment
Open

Feature Request: More granular colour selectors #286

No1InParticular opened this issue Jan 28, 2025 · 1 comment

Comments

@No1InParticular
Copy link

Hello, first want to say big thanks for the application it has helped me get started very nicely, first keyboard built (and learnt soldering) so having this really sped up testing my own layouts for first time.

Case

Currently I am having to set colors manually so I get exactly what I want which is a bit of a pain when trying to use the editor for other modifications as that pushes to branch which builds, I then modify locally and push again to wait for another build with exact values

Suggestion

I would love a more granular colour selector i.e a Hue, Saturation and Brightness input below the colour map/slider
Something like https://www.npmjs.com/package/@uiw/react-color-editable-input-hsla (I think I saw you using react-color?)
Can of course hide the alpha value since it won't be needed

Again thanks for this editor 😄

@nickcoutsos
Copy link
Owner

I can take a look, I don't think it should be too much trouble even if I'm just slapping my own input fields on. One thing to note, however, is that these colour space mappings aren't always perfect. ZMK does its own conversion from HSV to RGB, and different LEDs (or LED manufacturers, maybe) may not reproduce the exact same colours.

I can see how grueling it would be to go through that process repeatedly looking for the right colour as it appears on your keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants