Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better looking and more descriptive error messages. #22

Open
nick1n opened this issue Mar 5, 2012 · 7 comments
Open

Better looking and more descriptive error messages. #22

nick1n opened this issue Mar 5, 2012 · 7 comments

Comments

@nick1n
Copy link
Owner

nick1n commented Mar 5, 2012

The various error messages returned from last.fm's api:
2 : Invalid service - This service does not exist
3 : Invalid Method - No method with that name in this package
4 : Authentication Failed - You do not have permissions to access the service
5 : Invalid format - This service doesn't exist in that format
6 : Invalid parameters - Your request is missing a required parameter
7 : Invalid resource specified
8 : Operation failed - Something else went wrong
9 : Invalid session key - Please re-authenticate
10 : Invalid API key - You must be granted a valid key by last.fm
11 : Service Offline - This service is temporarily offline. Try again later.
13 : Invalid method signature supplied
16 : There was a temporary error processing your request. Please try again
26 : Suspended API key - Access for your account has been suspended, please contact Last.fm
29 : Rate limit exceeded - Your IP has made too many requests in a short period

@namklabs
Copy link
Collaborator

namklabs commented Mar 5, 2012

Errors should be reflected in the interface. Bootstrap has a bunch of built-in error classes for various elements. I don't think a regular javascript alert box is good enough. How do we want to present errors? I might suggest the Alert plugin: http://twitter.github.com/bootstrap/javascript.html#alerts

@namklabs
Copy link
Collaborator

namklabs commented Mar 5, 2012

What do you think about logging errors so we can monitor them?

@nick1n
Copy link
Owner Author

nick1n commented Mar 5, 2012

Yep, I was also thinking of bootstrap's error alerts, and we can log them, but how would we do that?

@namklabs
Copy link
Collaborator

namklabs commented Mar 9, 2012

We might have to use AJAX. I don't know anything about it yet though, lol. It might involve some PHP too. I'm thinking the error would be sent via AJAX to a PHP script that logs the error either in a text file or a database. If we are logging info, we should have a terms of use statement.

@nick1n
Copy link
Owner Author

nick1n commented Mar 9, 2012

You know we don't need logging, but if we want it, what about sending them via email? Don't know if that will be better or worse, but if we did do ajax we would probably need some simple page to accept and just logs them, and actually thinking about it, it shouldn't be too difficult to setup.

@nick1n
Copy link
Owner Author

nick1n commented May 1, 2013

Well, since we started logging, mid November, these are the error messages users have gotten:
6: No user with that name was found (43, 25)
8: Error fetching recent tracks (38, 15)
4: This user has made their recent tracks private. Only they can access them with an authenticated session (15, 12)
29: Rate limit exceeded (18, 4)

Note:
The numbers in parenthesis are (total events, unique events) unique events are a bit more import, because that number is closer to the number of actual users that are getting these errors.

So, I'm thinking we should probably take a little time and maybe help explain these particular errors to the user a little more thoroughly, and maybe even help suggest how to fix it. :)

@nick1n
Copy link
Owner Author

nick1n commented Jan 6, 2014

With version 0.4.0, Rate limit exceeded errors are handled by the last.fm module now.

Need to look into "8: Error fetching recent tracks," might be able to handle this error the same way...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants