Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only underline links in header upon hover #1136

Open
wants to merge 3 commits into
base: header-breaking-changes
Choose a base branch
from

Conversation

paulrobertlloyd
Copy link
Contributor

Description

Updates all links in the header component to only appear underlined upon hover.

Related discussion:

Checklist

Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@anandamaryon1
Copy link
Collaborator

@paulrobertlloyd
Overall I like it, but now we do have a slight issue whereby account information and links are not distinguished visually. Feels very non-optimal for users to not be sure whether an item is a link or not.

@frankieroberto
Copy link
Contributor

@paulrobertlloyd Overall I like it, but now we do have a slight issue whereby account information and links are not distinguished visually. Feels very non-optimal for users to not be sure whether an item is a link or not.

Maybe this is a reason to recommend ONLY putting links in the account section of the header? If you need to show the current user’s name or email, those could be clickable to a profile/settings type page?

@anandamaryon1
Copy link
Collaborator

@paulrobertlloyd Overall I like it, but now we do have a slight issue whereby account information and links are not distinguished visually. Feels very non-optimal for users to not be sure whether an item is a link or not.

Maybe this is a reason to recommend ONLY putting links in the account section of the header? If you need to show the current user’s name or email, those could be clickable to a profile/settings type page?

Hmm interesting. I was assuming we would have services that are fairly simple / MVP that do not have account settings pages, but I suppose you could at least link to a page that says "You are logged in as Mr.X" or "Your role is Admin", etc. ?

@frankieroberto
Copy link
Contributor

@anandamaryon1 maybe? Worth noting that we already don’t have the underline on the service name, and #1109 technically proposes allowing both the NHS logo or service name to not be linked (although probably we’d recommend that both should be linked most of the time?).

@frankieroberto
Copy link
Contributor

(Feels like there’s a reasonable expectation for everything in the header to be clickable, even if the Nunjucks params don’t technically enforce it?)

@paulrobertlloyd
Copy link
Contributor Author

Overall I like it, but now we do have a slight issue whereby account information and links are not distinguished visually. Feels very non-optimal for users to not be sure whether an item is a link or not.

This is easier to address on the white version of the header, whereby non-linked items could use a different text colour, either the text colour or as I have here, the secondary text colour:

White header with non-linked text in account area.

It’s harder to achieve something like that on a blue background though. Here’s a quick try, I tested the values in a contrast checker and they do pass, so maybe it’s a goer?

Blue header with non-linked text in account area.

When it comes to logos/service names, I’m not sure whether the same rule should apply… possibly for an unlinked service name, but the NHS logo and organisational logos should remain untouched. Maybe this is something we only need account for in the account area?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants