Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Sass to 1.77.5 and fix as many deprecations as possible #1064

Merged
merged 20 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cfeb0ea
Upgrade sass to 1.83.4 (embedded)
frankieroberto Nov 3, 2024
22509b3
Change to namespaced functions
frankieroberto Feb 12, 2025
b008ad2
Stop using darken() for button hover
frankieroberto Nov 3, 2024
3c909a7
Use sass color adjust function
frankieroberto Nov 14, 2024
4d67407
Change to namespaced functions (vendor)
colinrotherham Feb 12, 2025
3792f6f
Allow Sass `import` until migration to Sass modules
colinrotherham Feb 12, 2025
66e4104
Allow Sass `mixed-decl` until nesting supported by Stylelint
colinrotherham Feb 12, 2025
de97052
Downgrade Sass to avoid deprecations
colinrotherham Feb 14, 2025
05de1b6
Update to `sass-mq@6.0.0`
colinrotherham Feb 14, 2025
b5d2b4c
Update `sass-mq@6.0.0` for backwards compatibility
colinrotherham Feb 14, 2025
cfceba9
Merge branch 'main' into upgrade-sass
frankieroberto Feb 19, 2025
aa7ea82
Update button hover colors to match current darken values
frankieroberto Feb 19, 2025
932b8f1
Merge branch 'main' into upgrade-sass
colinrotherham Feb 19, 2025
92c5f13
Merge branch 'main' into upgrade-sass
colinrotherham Feb 19, 2025
c9d23f2
Restore colours until `darken()` is supported by `color.adjust()`
colinrotherham Feb 19, 2025
9fb32e8
Merge branch 'main' into upgrade-sass
colinrotherham Feb 19, 2025
d65aeae
Save backstop report on error
colinrotherham Feb 19, 2025
956ebca
Merge branch 'main' into upgrade-sass
colinrotherham Feb 20, 2025
a74cf47
Add tests for Sass versions
colinrotherham Feb 20, 2025
c67be7d
Fix missed Sass globals in `sass-mq`
colinrotherham Feb 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ jobs:
run: npm run test:visual

- name: Save backstop report
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: Backstop report
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const postcss = require('gulp-postcss')
const rename = require('gulp-rename')
const gulpSass = require('gulp-sass')
const terser = require('gulp-terser')
const dartSass = require('sass')
const dartSass = require('sass-embedded')
const webpack = require('webpack-stream')

const { version } = require('./package.json')
Expand Down
Loading