Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash as Division SASS Deprecation #752

Closed
britannio opened this issue Jul 1, 2021 · 2 comments
Closed

Slash as Division SASS Deprecation #752

britannio opened this issue Jul 1, 2021 · 2 comments

Comments

@britannio
Copy link

Bug Report

What is the issue?

https://sass-lang.com/documentation/breaking-changes/slash-div
The deprecated division operator is being used in SASS files thus producing a series of warnings.

A migration tool is available to fix this issue: https://sass-lang.com/documentation/breaking-changes/slash-div#automatic-migration

What steps are required to reproduce the issue?

What was the environment where this issue occurred?

  • Device:
  • Operating System:
  • Browser:
  • Browser version:
  • NHS.UK frontend package version:
  • Node version:
  • npm version:

Is there anything else you think would be useful in recreating the issue?

@SamNHS
Copy link

SamNHS commented Jul 1, 2021

This will also need an update to the package.json as it is currently "sass": "^1.32.11" and math.div requires sass 1.33 or later

@colinrotherham
Copy link
Contributor

Looks like this one was completed in 7f557f0

We've also made wider user of math.div() and math.percentage() in a671e04 and others in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants