Skip to content

Commit

Permalink
Updated version number, cran-comments and NEWS
Browse files Browse the repository at this point in the history
  • Loading branch information
chrismainey committed Apr 11, 2024
1 parent 66c5d7a commit eaf761a
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 41 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: FunnelPlotR
Type: Package
Title: Funnel Plots for Comparing Institutional Performance
Version: 0.4.9999
Version: 0.5.0
Authors@R: c(
person("Chris", "Mainey", ,"c.mainey1@nhs.net", role= c("aut", "cre"),
comment = c(ORCID ="0000-0002-3018-6171")
Expand Down
12 changes: 12 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# FunnelPlotR 0.5.0

- Breaking change
* Tidyeval approach added, with function now taking the data argument first, allowing piping, and allows unquoted column names to fit with tidyverse / dplyr style approach.

- Changes
* Added a `max.overlaps` argument to allow the user to vary this in cases where labels overlap is unhelpful.
* Changed control limit options to allow both adjusted and unadjusted to be turned off, without turning the other on.
* Updated README, help files and vignette to use tidyeval approach.



# FunnelPlotR 0.4.2
- Changes:
* Handling of expected values in SHMI calculation was adjusted to allow rounding to two decimal places to match NHSD publication, and as requested by HED Team. Now controlled with additional argument: `SHMI_rounding` = TRUE/FALSE
Expand Down
50 changes: 10 additions & 40 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,62 +1,32 @@
## Release summary

### Resubmission - 01/06/2023
I have updated some of the URLS to the most current DOI for for references, made links all https, included trailing slashes where they resolve. All other links tested and current.
Updated Github reference in vignette, and deprecated arguments for ggplot2 in other vignette.
This is a main release with a change to the UI and some of the logic of the main plotting function:
* Implements tidyeval style interface to allow users to 'pipe' into it from dplyr
* Adjusted support material to reflect that.
* Updated control limit logical to allow turning in all limits.

Resolved 2 CRAN checks NOTES: lost braces in a file due to line breaks, and renamed arguments were missed in one function leading to 'documented arguments not in \usage'. Apologies for the delay, the CRAN emails were filter to my junk folder and hadn't spotted them until this week.


This is a bug-fix release for the FunnelPlotR package:
* an error handling function was not performing correctly and preventing multiple selections.
* A logic step for dealing OD adjustment if there is no OD.
* Updated plotting as ggplot arguments were deprecated and giving warning notices.
* Updated package author's email address, as I lost access to the old one.
* Updated bits of meta data, codecov, roxygen2 version and github actions.
* Added additional unit tests.
* Update package author email address

*Please note: I have lost access to my previous email address, used as author and was not
able to change it. This submission has a new email address, but I can't confirm from the old
one. Please correspond with c.mainey1@nhs.net*

## Test environments
* local windows 10, R 4.2.2
* local windows 10, R 4.3
* local windows 10, R 4.3.2

* R-devel, on Win-builder

* GitHub actions:
* Mac OS x 12.6.5 21G531, R 4.3
* Mac OS x 12.7.4 21H123, R 4.3.3
* Windows Server x64 2022, 10.0.20348, R 4.3
* Windows Server x64 latest, R 3.6.3
* Ubuntu 20.04.6 LTS, R-devel 2023-05-31 - Failed, Error in loadNamespace(x) : there is no package called ‘rcmdcheck’ - this appears to be missing the rlib github actions
* Ubuntu 20.04.6 LTS, R 4.3
* Ubuntu 20.04.6 LTS, R-devel 2023-05-31
* Ubuntu 20.04.6 LTS, R 4.3.3

* r-hub:
* Ubuntu Linux 20.04.1 LTS, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran
* Windows Server 2022, R-devel, 64 bit

## R CMD check results
There were no ERRORs or WARNINGs.

All checks reported NOTE of new maintainer vs. old maintainer.
R-hub Linux NOTES:
'Skipping checking HTML validation: no command 'tidy' found'
'Skipping checking math rendering: package 'V8' unavailable'

R-hub Windows NOTES:
Skipping checking math rendering: package 'V8' unavailable
* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
''NULL''
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'

I am unable to find the files described above, and believe it's an artefact of the build on R-Hub.
No such NOTES on GitHub actions or local build.

There were no ERRORs, WARNINGs or NOTES.

## Downstream dependencies
There are currently no downstream dependencies for this package to my knowledge.

0 comments on commit eaf761a

Please sign in to comment.