How do I update requestStatus when using skipWhileCached

[dexster]

Normally a service will update the store like so and also update the request Status as well

service

 return http.get(todosUrl).pipe(
    tap(setTodos),
...

store

export function setTodos(todos: Todo[]) {
  store.update(
    addEntities(todos),
    updateRequestStatus('todos', 'success'),

But when using cache and specifying skipWhileCached on the service, then the store update() is not called so I'm not sure where to add updateRequestStatus to change the status from pending to success

return http.get(todosUrl).pipe(
   tap(setTodos(todos)),
   skipWhileTodosCached('todos')

Will I have to use one of the cache queries somewhere in the API call flow to set the status or do you think we could add some means of setting the status to skipWhileCached?

[NetanelBasal]

That's the purpose of skipWhileCached. There is no need to update anything because that value is in the cache.

[dexster]

Thank for the reply. I do get that but when I call my service the second time it still sets the request status back to pending and then I'm not sure where to set it back to success, as it (correctly) does not call the store.update which is where I currently set the request status to 'success'

I noticed that when I change to using the createRequestDataSource and todosDataSource.skipWhileCached() in my API call then it does not set the requestStatus to pending when I call the API the second time.

So the first example below will reset the status to pending for the second API call, but the second example does not

export function fetchTodos() {
  return http.get(todosUrl).pipe(
    tap(setTodos),
    trackTodosRequestsStatus('todos'),
    skipWhileTodosCached('todos')
  );
}

export function fetchTodos() {
  return http.get(todosUrl).pipe(
    tap(setTodos),
        todoDataSource.trackRequestStatus(),
        todoDataSource.skipWhileCached()
  );
}
  

[NetanelBasal]

It should work with the latest version. I also added specs if you want to see:

https://github.com/ngneat/elf/blob/master/packages/requests/src/lib/integration.spec.ts

[dexster]

Looks good. Thanks for the quick response