State history, insertion

[mikkel-ol]

When undoing history and modifying the store, the new history state gets inserted in between history states i.e. past and future. Example

         current
            v
1 --> 2 --> 3

undo()

   current
      v
1 --> 2 --> 3

update store

             current
                v
1 --> 2 --> *new* 3 --> (old 3) 4

redo()

                          current
                             v
1 --> 2 --> *new* 3 --> (old 3) 4

This can be confusing when using state history like many other applications, where undoing and applying a new state deletes future states.

I suggest either changing this or providing a configuration flag to delete future when updating store.

[johnfewell]

I agree, this is very counterintuitive. The future should be deleted when there are new state revisions.

[johnfewell]

@mikkel-ol I submitted a PR.