Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify export via TLS (#12). #83

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Verify export via TLS (#12). #83

merged 1 commit into from
Dec 21, 2024

Conversation

jimf5
Copy link
Collaborator

@jimf5 jimf5 commented Dec 20, 2024 •
edited
Loading

Proposed changes

Verify export via TLS (#12).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@jimf5 jimf5 requested a review from p-pautov December 20, 2024 06:50
@jimf5 jimf5 self-assigned this Dec 20, 2024
p-pautov
p-pautov reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@p-pautov p-pautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message doesn't look like a sentence.

tests/test_otel.py Outdated Show resolved Hide resolved
tests/trace_service.py Outdated Show resolved Hide resolved
@jimf5 jimf5 force-pushed the tests_tls_endpoint branch from f5f4715 to 67068ff Compare December 20, 2024 22:59
@jimf5 jimf5 requested a review from p-pautov December 20, 2024 23:12
p-pautov
p-pautov reviewed Dec 21, 2024
View reviewed changes
tests/trace_service.py Outdated Show resolved Hide resolved
@jimf5 @p-pautov
Verify export via TLS (#12).
78fea3e 
Co-authored-by: Pavel Pautov <p.pautov@f5.com>
@jimf5 jimf5 force-pushed the tests_tls_endpoint branch from f0f001f to 78fea3e Compare December 21, 2024 01:30
@jimf5 jimf5 changed the title Verify support export via TLS (#12). Verify export via TLS (#12). Dec 21, 2024
@jimf5 jimf5 requested a review from p-pautov December 21, 2024 01:31
@jimf5 jimf5 merged commit f578402 into main Dec 21, 2024
1 check passed
@jimf5 jimf5 deleted the tests_tls_endpoint branch December 21, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-pautov p-pautov p-pautov approved these changes

Assignees

@jimf5 jimf5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimf5 @p-pautov