Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update command for RHEL NIM install #156

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Update update command for RHEL NIM install #156

merged 2 commits into from
Feb 4, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 31, 2025

Proposed changes

Missing command detail, based on feedback

Once we've clarified whether this applies to other commands, we'll move it from Draft to Review

The new command seems to work in my RHEL 9 VM

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@mjang mjang self-assigned this Jan 31, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/156/

@mjang mjang marked this pull request as ready for review January 31, 2025 15:09
@mjang mjang requested a review from a team as a code owner January 31, 2025 15:09
Copy link

@vvnginx vvnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ship it!

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: approving despite the procedural discussion, so as not to block the PR beyond the 2 approvals requirement.

@mjang mjang merged commit 4ba7778 into main Feb 4, 2025
8 checks passed
@mjang mjang deleted the fix-nim-update branch February 4, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants