Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing issues reported in 2.18.0 release #142

Merged
merged 13 commits into from
Feb 3, 2025

Conversation

bejjrajesh
Copy link
Contributor

Proposed changes

The following changes are made to the install script in support of the NIM 2.19.0 release.

  1. The Security Module is no longer a separate module from NIM. It will be part of the NIM from 2.19.0. The -s option is updated to give a warning saying SM comes by default and not needed to be installed separately.
  2. New option -f is added to support setting the FQDN name to be used for generating the certs for NIM.
  3. Fixed the bug if the mgmt block is already present, do not add new block again.
  4. Added new option -l that prints the list of supported distributions where script can be executed.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@bejjrajesh bejjrajesh requested a review from a team as a code owner January 29, 2025 18:31
Copy link

github-actions bot commented Jan 29, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommending changes

static/scripts/install-nim-bundle.sh Outdated Show resolved Hide resolved
static/scripts/install-nim-bundle.sh Outdated Show resolved Hide resolved
static/scripts/install-nim-bundle.sh Outdated Show resolved Hide resolved
static/scripts/install-nim-bundle.sh Outdated Show resolved Hide resolved
@mjang
Copy link
Contributor

mjang commented Jan 29, 2025

recheck

@bejjrajesh
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@bejjrajesh
Copy link
Contributor Author

recheck

@mjang
Copy link
Contributor

mjang commented Jan 30, 2025

@travisamartin IMO this is ready. If you agree, you're welcome to merge.

@mjang
Copy link
Contributor

mjang commented Jan 31, 2025

@bejjrajesh Your most recent commit w/r/t curl makes sense to me.

@mjang
Copy link
Contributor

mjang commented Feb 3, 2025

Merging with validation from internal QA.

@mjang mjang merged commit a7fd19c into nginx:main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants