-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix flake check
with no-url-literals
fails
#39
Comments
nix flake check
fails with no-url-literals
nix flake check
with no-url-literals
fails
Yes, the use of mach-nix for liberaforms (which is what uses an IDF) depended on an old version of nixpkgs as a workaround to a bug a with mach-nix DavHau/mach-nix#549 which made it incompatible with newer versions of nixpkgs. That is documented here: https://github.com/ngi-nix/ngipkgs/blob/main/pkgs/liberaforms/env.nix#L9-L16 it was from back in June when we set up ngipkgs with liberaforms as the initial test service. Since then, I see that in early July a new PR was merged for mach-nix DavHau/mach-nix#563 that apparently fixes the incompatibility with newer nixpkgs. Assuming this fix works, then in theory this issue could be resolved by sourcing the import of mach-nix for liberaforms from its master branch (to include the fix) and then removing the old nixpkgs workaround. I tried this here: https://github.com/ngi-nix/ngipkgs/tree/remove-old-nixpkgs but ran into an error that I will document in a new issue. |
As expected, this seems to have been resolved by #41. I just ran the check on the main branch of ngipkgs and it completed without an error so I'm going to close the issue:
|
IMO, |
My two cents: not enforced == not resolved |
Sure, CI enforcement seems like a reasonable addition to this issue. I'll review #44 now. |
Background
URL literals are deprecated:
There was at least one treewide commit in nixpkgs removing URL literals three years ago, which rewrote a URL literal in the definition of the
prettytable
(Python) package.I think that ngipkgs should evaluate with
no-url-literals
.Problem
Today, I tried:
Note that this is nixpkgs:
I tried to find the reason for this dependency using
nix why-depends
:Since there's also an IFD involved (see also #24), it might well be that the evaluation of the IFD depends on a version of nixpkgs that is old.
Suggestions
The text was updated successfully, but these errors were encountered: