Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out umi handling #1466

Merged
merged 15 commits into from
Dec 12, 2024
Merged

Factor out umi handling #1466

merged 15 commits into from
Dec 12, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Dec 10, 2024 •
edited
Loading

This PR moves UMI handling out to a subworkflow, the tests in place ensure there's no change to the overall logic.

I've also stripped a function from the config, I don't think it was helpful.

With this in place and testing, I can also deploy it in riboseq.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords marked this pull request as draft December 10, 2024 11:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited by nf-core-bot
Loading

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8377720

+| ✅ 188 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-12 17:13:31

@pinin4fjords pinin4fjords changed the base branch from master to dev December 10, 2024 16:33
@pinin4fjords pinin4fjords mentioned this pull request Dec 11, 2024
Merged
11 tasks
@pinin4fjords
Copy link
Member Author

@nf-core-bot fix linting

@pinin4fjords pinin4fjords marked this pull request as ready for review December 12, 2024 15:26
maxulysse
maxulysse approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests pass, it's proof nothing has changed and you can merge

@pinin4fjords
Copy link
Member Author

Thanks @maxulysse !

@pinin4fjords pinin4fjords merged commit 4749877 into dev Dec 12, 2024
30 checks passed
@pinin4fjords pinin4fjords deleted the factor_out_umi branch December 12, 2024 17:35
@pinin4fjords pinin4fjords mentioned this pull request Dec 12, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @maxulysse