Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] remove isMaster block to see how it affects the matrix (master) #1436

Closed
wants to merge 91 commits into from

Conversation

adamrtalbot
Copy link
Contributor

  • Install kraken2 and bracken
  • Change nextflow configurations
  • Initial addition of kraken and bracken to pipeline
  • Fix include statements
  • Fix include statements
  • Include module config files
  • Use presence of kraken_db to determine bracken run, add save params
  • Fix multiqc for Bracken/Kraken
  • Add Bracken/Kraken citations
  • Fix bracken config
  • Update bracken
  • Adjust multiqc configs for updated bracken
  • Add input validation and update scheme
  • Change default Bracken precision to species
  • Debug input validation
  • Documentation/output image
  • Update changelog
  • Update Kraken2 module
  • Linting
  • Change to --contaminant_screening param
  • Fixing save unaligned default
  • Debugging
  • Update usage
  • Provide motivation for Kraken2 parameters
  • Fix typo
  • Update metro map
  • Update schema
  • Update docs/usage.md
  • Change output directory for kraken2/bracken
  • Update main.nf
  • Update Changelog
  • Another changelog fix
  • Update CHANGELOG.md
  • Linting fix
  • make snapshot versions pretty
  • update CHANGELOG
  • update all snapshots
  • update half of all snaps
  • more snapshots
  • update snapshots
  • update snapshots
  • Update CHANGELOG.md
  • update snapshots
  • do not sort output
  • sort output by PATH
  • nf-core pipelines bump-version 3.16.0dev
  • update snapshots
  • update CHANGELOG
  • Update CHANGELOG.md
  • snapshot more files
  • snapshot more files
  • feature counts snapshots
  • typo
  • more snapshots
  • more snapshots
  • update snapshots
  • better regex
  • fix regex
  • better regex
  • update snapshot
  • code polish
  • rescue some snaps
  • Apply suggestions from code review
  • tiny refactor part I
  • tiny refactor part II - IT IS GROOVY WE CAN SUBSTRACT 🤦
  • update regexes
  • move pipeline regexes in UTILS_PIPELINE
  • simplify regexes
  • fix regexes
  • Merge conflcits
  • Update hisat2 patch
  • (Hopefully) final linting fix
  • Change PR number
  • snapshots all filenames
  • code polish
  • typo
  • Apply suggestions from code review
  • update CHANGELOG
  • update animated metro_map
  • no snpashots of tasks size for workflow for remove_ribo_rna
  • snapshot number of sucessful tasks
  • typo
  • Update tests/featurecounts_group_type.nf.test
  • why was this not commited?
  • patch bedtools/genomecov to use quay.io to solve issue with nf-core download
  • use url for singularity
  • use proper url for singularity
  • prepare RC 3.15.2
  • update version in snapshots too
  • use nft-utils
  • update nftignore
  • update pipeline versions in snapshot
  • update CHANGELOG
  • update nftignore
  • update nftignore
  • 3.16.0 instead of 3.15.2
  • Update CHANGELOG.md
  • use nft-utils 0.0.2 to get relative path in snapshots
  • forgot a merge
  • Apply suggestions from code review
  • nf-core pipelines bump-version 3.17.0dev
  • Bump version in CHANGELOG
  • Bump versions in snap
  • Template update for nf-core/tools version 3.0.0
  • Template update for nf-core/tools version 3.0.1
  • fix merge conflicts
  • Apply suggestions from code review
  • fix nf-core lint
  • install nf-test 0.9.0
  • install nf-test once only
  • use proper Channel factory
  • rename function test
  • fix align
  • fix samplesheet usage
  • fix tests
  • fix tests
  • update CHANGELOG
  • Apply suggestions from code review
  • update test adjacent files
  • clean nftignore for kallisto
  • minor code polish
  • kallisto: update snapshots
  • update plugin version
  • update nftignore
  • update fastq_fastqc_umitools_trimgalore
  • update nftignore and snapshots for salmon and kallisto
  • no set -C until we fix modules upstream
  • update nftignore
  • update default tests
  • update featurecounts_group_type tests
  • update nftignore and hisat2 snapshots
  • update min_mapped_reads snapshots
  • do not snapshot the bam
  • update remove_ribo_rna tests
  • update skip_qc tests
  • update skip_trimming snapshots
  • Update subworkflow to fix variable
  • update changelog
  • update last snapshots
  • ignore file
  • Correct CHANGELOG
  • only one samplesheetToList
  • update CHANGELOG
  • Template update for nf-core/tools version 3.0.2
  • fix GHA
  • fix GHA
  • fix GHA
  • fix snapshots
  • :shakefist:
  • Fix ifEmpty() issues with trimming
  • Update CHANGELOG
  • Update rnaseq prepro
  • Reset versions back to 3.16.1 for patch release
  • Update changelog
  • disable conda pipeline level tests + update CHANGELOG
  • fix PR link
  • Properly disable conda pipeline level tests
  • Update CHANGELOG.md
  • Bump versions back to 3.17.0 after release
  • Update CHANGELOG
  • Prettier
  • appy changes for ARM
  • Fix up config
  • Reset environment ymls
  • Reset main.nfs with software changes only
  • Link sw configs to arm profile
  • Add process block
  • note pins
  • Remove conda overrides that were having no impact
  • Use different RSEQC pin
  • update BEDGRAPHTOBIGWIG pin
  • Fix annotation
  • Don't think we need the RSEQC pin
  • correct ucsc
  • Triage arm deps
  • Non-igenomes STAR can use the latest star
  • remove rogue comment
  • update arm conf
  • Bump lots of modules so that conda versions have arm builds
  • Update prepare_genome snaps
  • Update align_star snaps
  • Update quantify_rsem snaps
  • [skip ci] First batch of pipeline test updates
  • [skip ci] Update subworkflow snaps due to patch on module
  • [skip ci] bump remove_ribo_rna snaps
  • [skip ci] Update snaps for --pseudo_aligner salmon --skip_qc --skip_alignment
  • [skip ci] update star_rsem pipeline snaps
  • [skip ci] update pipeline tests for skip_qc
  • update skip_trimming snaps
  • update changelog
  • Revert hisat diff
  • remove excess newlines
  • Bump star modules
  • Update option for new STAR
  • Fix up pipeline tests
  • Fix local star swf to match star
  • update changelog
  • patch sortmerna to 4.3.7 in seqera channel pending a functional verison appearing in conda-forge
  • Update changelog
  • fix sortmerna tests for order
  • update a relevant pipeline test
  • Cut out module redundant software overrides
  • Add frozen ARM builds
  • Container directives for conda overrides
  • Temporary Trimgalore override, singularity fixes for rsem processes
  • update docs
  • Fix argument conflict between STAR versions
  • Fix config error
  • Correction to star rsem
  • Refine config setup
  • Bump trimgalore module
  • Fix up ARM profile for updated trim-galore
  • Apply suggestions from code review
  • Apply suggestions from code review
  • Add notes for kraken2/ braken
  • Update docs
  • prettier
  • lint fix
  • [skip ci] Reorg ARM bits
  • Update arm.config
  • Fix syntax error
  • revert trimgalore tweak to appease linter
  • Update pipeline-level tests
  • Update CHANGELOG
  • Bump versions
  • update changelog
  • update CHANGELOG
  • update and patch modules
  • Remove isMaster block from CI

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @adamrtalbot,

It looks like this pull-request is has been made against the nf-core/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

Copy link

github-actions bot commented Oct 23, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0acaeb4

+| ✅ 188 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-23 17:09:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants